ESQL: Fix LogicalPlanOptimizerTests testPlanSanityCheckWithBinaryPlans #118672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
added
the
auto-merge-without-approval
|
CI is only failing due to https://github.com/elastic/elasticsearch-serverless/issues/3281, so I'm going to go and merge instead of waiting for the mute to kick in. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Dec 13, 2024
elastic#118672) (cherry picked from commit 54e839b) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
elastic#118672) (elastic#118689) (cherry picked from commit 54e839b) # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118656
The test expectation needs to adjusted now that we push down limits past JOINs.